Skip to content

[hermes] Update some integration tests#3162

Closed
joshlf wants to merge 1 commit intoGliiuhmmjpxnlhekzzccdf2jteq6louuwfrom
Gftcay6e46fu54jc6ytsszqb3b4rah7dj
Closed

[hermes] Update some integration tests#3162
joshlf wants to merge 1 commit intoGliiuhmmjpxnlhekzzccdf2jteq6louuwfrom
Gftcay6e46fu54jc6ytsszqb3b4rah7dj

Conversation

@joshlf
Copy link
Copy Markdown
Member

@joshlf joshlf commented Mar 29, 2026

Delete some obsolete tests. Mark some tests as FIXME.


Latest Update: v9 — Compare vs v8

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gftcay6e46fu54jc6ytsszqb3b4rah7dj && git checkout -b pr-Gftcay6e46fu54jc6ytsszqb3b4rah7dj FETCH_HEAD

Checkout

git fetch origin refs/heads/Gftcay6e46fu54jc6ytsszqb3b4rah7dj && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gftcay6e46fu54jc6ytsszqb3b4rah7dj && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gftcay6e46fu54jc6ytsszqb3b4rah7dj

Stacked PRs enabled by GHerrit.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf joshlf changed the title [hermes] Fix some integration tests [hermes] Update some integration tests Mar 29, 2026
@joshlf joshlf force-pushed the Gftcay6e46fu54jc6ytsszqb3b4rah7dj branch from 51366f1 to 152bdaa Compare March 29, 2026 20:31
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (b183481) to head (2cec7d6).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           Gliiuhmmjpxnlhekzzccdf2jteq6louuw    #3162   +/-   ##
==================================================================
  Coverage                              91.85%   91.85%           
==================================================================
  Files                                     20       20           
  Lines                                   6067     6067           
==================================================================
  Hits                                    5573     5573           
  Misses                                   494      494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf joshlf force-pushed the Gftcay6e46fu54jc6ytsszqb3b4rah7dj branch from 152bdaa to 2a1071c Compare March 29, 2026 21:10
@joshlf joshlf changed the base branch from Gr4qottxa22y4kfhk2a5vctnhsswyoiac to Gliiuhmmjpxnlhekzzccdf2jteq6louuw March 29, 2026 21:10
@joshlf joshlf force-pushed the Gliiuhmmjpxnlhekzzccdf2jteq6louuw branch from f2b45f9 to 39a4877 Compare March 29, 2026 21:39
@joshlf joshlf force-pushed the Gftcay6e46fu54jc6ytsszqb3b4rah7dj branch from 2a1071c to 87c07d6 Compare March 29, 2026 21:39
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf joshlf force-pushed the Gliiuhmmjpxnlhekzzccdf2jteq6louuw branch from 39a4877 to b232afc Compare March 29, 2026 21:43
@joshlf joshlf force-pushed the Gftcay6e46fu54jc6ytsszqb3b4rah7dj branch from 87c07d6 to f18184c Compare March 29, 2026 21:43
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf joshlf force-pushed the Gftcay6e46fu54jc6ytsszqb3b4rah7dj branch from f18184c to 6fea15a Compare March 29, 2026 21:49
@joshlf joshlf force-pushed the Gliiuhmmjpxnlhekzzccdf2jteq6louuw branch from b232afc to 080e06a Compare March 29, 2026 21:49
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf joshlf force-pushed the Gliiuhmmjpxnlhekzzccdf2jteq6louuw branch from 080e06a to 5198c12 Compare March 29, 2026 21:57
@joshlf joshlf force-pushed the Gftcay6e46fu54jc6ytsszqb3b4rah7dj branch from 6fea15a to dc9224e Compare March 29, 2026 21:57
@joshlf joshlf changed the base branch from Gliiuhmmjpxnlhekzzccdf2jteq6louuw to Gu3jbyvuclngofhachlav5ngh4i7ltxh2 March 29, 2026 21:57
@joshlf joshlf force-pushed the Gftcay6e46fu54jc6ytsszqb3b4rah7dj branch from dc9224e to bc85003 Compare March 29, 2026 22:26
@joshlf joshlf force-pushed the Gu3jbyvuclngofhachlav5ngh4i7ltxh2 branch from 6a0cdf5 to c361cf7 Compare March 29, 2026 22:26
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

Delete some obsolete tests. Mark some tests as `FIXME`.

gherrit-pr-id: Gftcay6e46fu54jc6ytsszqb3b4rah7dj
@joshlf joshlf force-pushed the Gftcay6e46fu54jc6ytsszqb3b4rah7dj branch from bc85003 to 2cec7d6 Compare March 29, 2026 22:48
@joshlf joshlf changed the base branch from Gu3jbyvuclngofhachlav5ngh4i7ltxh2 to Gliiuhmmjpxnlhekzzccdf2jteq6louuw March 29, 2026 22:48
@joshlf
Copy link
Copy Markdown
Member Author

joshlf commented Mar 29, 2026

Superseded by #3168

@joshlf joshlf closed this Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants