Move theme components to ui module#3597
Merged
andreia-ferreira merged 2 commits intomasterfrom Mar 9, 2026
Merged
Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project structure by extracting core domain logic and shared Compose UI theme components into dedicated Kotlin Multiplatform modules. This change enhances modularity, promotes code reuse across different platforms, and streamlines dependency management by centralizing version definitions. The refactoring prepares the codebase for future multiplatform development while ensuring a cleaner separation of concerns. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a significant refactoring that moves shareable theme components into a new core:ui module and introduces a core:domain module, preparing the project for a multi-platform architecture. The changes primarily involve moving files, updating imports, and configuring Gradle for the new Kotlin Multiplatform modules. The implementation is solid, but I've identified a few minor issues concerning copyright headers in the newly created files, which appear to violate the repository's style guide. Please see the detailed comments.
core/domain/src/commonMain/kotlin/org/groundplatform/domain/model/LoiReport.kt
Show resolved
Hide resolved
core/ui/src/commonMain/kotlin/org/groundplatform/ui/components/GroundQrCode.kt
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3597 +/- ##
============================================
- Coverage 70.33% 69.69% -0.65%
+ Complexity 1816 1811 -5
============================================
Files 353 349 -4
Lines 9895 9675 -220
Branches 1061 1060 -1
============================================
- Hits 6960 6743 -217
+ Misses 2300 2298 -2
+ Partials 635 634 -1
🚀 New features to boost your workflow:
|
andreia-ferreira
had a problem deploying
to
e2e-approval
GitHub Actions
Error
andreia-ferreira
had a problem deploying
to
e2e-approval
GitHub Actions
Error
andreia-ferreira
force-pushed
the
andreia/move-theme-to-ui-module
branch
from
13eeb85 to
65fb44f
Compare
andreia-ferreira
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
shobhitagarwal1612
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3600
This PR moves shareable components related to compose app theme to the
core:uimodule.Most of the changes are just import updates due to the theme files being moved. The only file with actual changes is
Typography, because some libraries used there weren't available in Compose Multiplatform.@shobhitagarwal1612 PTAL?