Skip to content

style(clippy): wrap constant assertions in const blocks in safeoutputs/mod.rs #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

style(clippy): wrap constant assertions in const blocks in safeoutputs/mod.rs #695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 25 additions & 26 deletions src/safeoutputs/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,31 +840,31 @@ mod tests {
#[test]
fn test_requires_write_consistency() {
// Write-requiring tools
assert!(CreateWorkItemResult::REQUIRES_WRITE);
assert!(CommentOnWorkItemResult::REQUIRES_WRITE);
assert!(UpdateWorkItemResult::REQUIRES_WRITE);
assert!(CreatePrResult::REQUIRES_WRITE);
assert!(CreateWikiPageResult::REQUIRES_WRITE);
assert!(UpdateWikiPageResult::REQUIRES_WRITE);
assert!(AddPrCommentResult::REQUIRES_WRITE);
assert!(LinkWorkItemsResult::REQUIRES_WRITE);
assert!(QueueBuildResult::REQUIRES_WRITE);
assert!(CreateGitTagResult::REQUIRES_WRITE);
assert!(AddBuildTagResult::REQUIRES_WRITE);
assert!(CreateBranchResult::REQUIRES_WRITE);
assert!(UpdatePrResult::REQUIRES_WRITE);
assert!(UploadBuildAttachmentResult::REQUIRES_WRITE);
assert!(UploadPipelineArtifactResult::REQUIRES_WRITE);
assert!(UploadWorkitemAttachmentResult::REQUIRES_WRITE);
assert!(SubmitPrReviewResult::REQUIRES_WRITE);
assert!(ReplyToPrCommentResult::REQUIRES_WRITE);
assert!(ResolvePrThreadResult::REQUIRES_WRITE);
const { assert!(CreateWorkItemResult::REQUIRES_WRITE) };
const { assert!(CommentOnWorkItemResult::REQUIRES_WRITE) };
const { assert!(UpdateWorkItemResult::REQUIRES_WRITE) };
const { assert!(CreatePrResult::REQUIRES_WRITE) };
const { assert!(CreateWikiPageResult::REQUIRES_WRITE) };
const { assert!(UpdateWikiPageResult::REQUIRES_WRITE) };
const { assert!(AddPrCommentResult::REQUIRES_WRITE) };
const { assert!(LinkWorkItemsResult::REQUIRES_WRITE) };
const { assert!(QueueBuildResult::REQUIRES_WRITE) };
const { assert!(CreateGitTagResult::REQUIRES_WRITE) };
const { assert!(AddBuildTagResult::REQUIRES_WRITE) };
const { assert!(CreateBranchResult::REQUIRES_WRITE) };
const { assert!(UpdatePrResult::REQUIRES_WRITE) };
const { assert!(UploadBuildAttachmentResult::REQUIRES_WRITE) };
const { assert!(UploadPipelineArtifactResult::REQUIRES_WRITE) };
const { assert!(UploadWorkitemAttachmentResult::REQUIRES_WRITE) };
const { assert!(SubmitPrReviewResult::REQUIRES_WRITE) };
const { assert!(ReplyToPrCommentResult::REQUIRES_WRITE) };
const { assert!(ResolvePrThreadResult::REQUIRES_WRITE) };

// Diagnostic tools (should NOT require write)
assert!(!NoopResult::REQUIRES_WRITE);
assert!(!MissingDataResult::REQUIRES_WRITE);
assert!(!MissingToolResult::REQUIRES_WRITE);
assert!(!ReportIncompleteResult::REQUIRES_WRITE);
const { assert!(!NoopResult::REQUIRES_WRITE) };
const { assert!(!MissingDataResult::REQUIRES_WRITE) };
const { assert!(!MissingToolResult::REQUIRES_WRITE) };
const { assert!(!ReportIncompleteResult::REQUIRES_WRITE) };
}

/// Verify ALL_KNOWN_SAFE_OUTPUTS has exactly the right count:
Expand Down Expand Up @@ -1190,12 +1190,11 @@ mod tests {
repository_name: Option<&str>,
allowed: std::collections::HashMap<String, String>,
) -> ExecutionContext {
let ctx = ExecutionContext {
ExecutionContext {
repository_name: repository_name.map(|s| s.to_string()),
allowed_repositories: allowed,
..Default::default()
};
ctx
}
}

#[test]
Expand Down