style(clippy): wrap constant assertions in const blocks in safeoutputs/mod.rs#695
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
…s/mod.rs Also drop unnecessary let binding in ctx_with helper (let_and_return). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What clippy found
Clipper reported 23
assertions_on_constantserrors and 1let_and_returnerror insrc/safeoutputs/mod.rs:How it was fixed
assertions_on_constants(23×) — wrapped everyassert!(CONST)andassert!(!CONST)in thetest_requires_write_consistencytest withconst { ... }blocks as suggested.let_and_return(1×) — removed the intermediatectxbinding inctx_withand returned theExecutionContextstruct literal directly.Files touched:
src/safeoutputs/mod.rsVerification
cargo build --all-targets✅cargo test✅cargo clippy --all-targets --all-features --workspace -- -D warnings— no errors insrc/safeoutputs/mod.rs✅Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
dev.azure.comSee Network Configuration for more information.