Skip to content

Update client error logging #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piceri merged 2 commits into from
Mar 13, 2026
Merged

Update client error logging #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9335a3
update client error logging
piceri Mar 13, 2026
80af440
add comments
piceri Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions pkg/deploymentrecord/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,15 +240,18 @@ func (c *Client) PostOne(ctx context.Context, record *DeploymentRecord) error {
continue
}

// Drain and close response body to enable connection reuse
_, _ = io.Copy(io.Discard, resp.Body)
_ = resp.Body.Close()

if resp.StatusCode >= 200 && resp.StatusCode < 300 {
// Drain and close response body to enable connection reuse
_, _ = io.Copy(io.Discard, resp.Body)
_ = resp.Body.Close()
dtmetrics.PostDeploymentRecordOk.Inc()
return nil
}

// Drain and close response body to enable connection reuse by reading body for error logging
body, _ := io.ReadAll(resp.Body)
_ = resp.Body.Close()

lastErr = fmt.Errorf("unexpected status code: %d", resp.StatusCode)

// Don't retry on client errors (4xx) except for 429
Expand All @@ -257,10 +260,18 @@ func (c *Client) PostOne(ctx context.Context, record *DeploymentRecord) error {
dtmetrics.PostDeploymentRecordClientError.Inc()
slog.Warn("client error, aborting",
"attempt", attempt,
"error", lastErr)
"error", lastErr,
"status_code", resp.StatusCode,
"msg", string(body),
)
return &ClientError{err: lastErr}
}
dtmetrics.PostDeploymentRecordSoftFail.Inc()
slog.Debug("retriable server error",
"attempt", attempt,
"status_code", resp.StatusCode,
"msg", string(body),
)
}

dtmetrics.PostDeploymentRecordHardFail.Inc()
Expand Down
Loading