Conversation
There was a problem hiding this comment.
Pull request overview
Updates deploymentrecord.Client.PostOne error handling to improve observability when the GitHub deployment records API returns non-2xx responses.
Changes:
- Moves response body draining/closing into the success branch and adds error-response body reading for logging.
- Expands client-error (4xx, excluding 429) logs with
status_codeand response body content. - Adds debug logging for retriable non-2xx responses including the response body.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
ajbeattie
approved these changes
Mar 13, 2026
malancas
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update deployment record client error logging to improve debugging capabilities.