Skip to content

Ref: remove yarn from stub update #5811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucas-zimerman merged 4 commits into from
Mar 13, 2026
Merged

Ref: remove yarn from stub update #5811

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de4f357
remove yarn dependency
lucas-zimerman Mar 13, 2026
3c3626e
Apply suggestion from @lucas-zimerman
lucas-zimerman Mar 13, 2026
f998d7d
fix path
lucas-zimerman Mar 13, 2026
1e1050f
Merge branch 'lz/android-stub-take2' of https://github.com/getsentry/…
lucas-zimerman Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/update-android-stubs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ set-version)
echo "${content/${BASH_REMATCH[0]}/$newValue}" >$file

# Rebuild the stubs jar and JS types
cd ..
yarn build:replay-stubs || true
cd replay-stubs
echo "Building Stub"
./gradlew jar
Copy link

@cursor cursor bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed || true causes script failure on build errors

Medium Severity

The old command yarn build:replay-stubs || true intentionally suppressed build failures so the version-update workflow could continue even if the jar build failed. The new ./gradlew jar invocation drops the || true guard while the script uses set -euo pipefail, meaning any Gradle failure now aborts the entire version-update process (including when called from update-android.sh). If this strictness is intentional it's fine, but since the PR description only mentions removing yarn (not changing error handling), this looks like an accidental behavior change.

Fix in Cursor Fix in Web

;;
*)
echo "Unknown argument $1"
Expand Down
Loading