Skip to content

Ref: remove yarn from stub update#5811

Merged
lucas-zimerman merged 4 commits intomainfrom
lz/android-stub-take2
Mar 13, 2026
Merged

Ref: remove yarn from stub update#5811
lucas-zimerman merged 4 commits intomainfrom
lz/android-stub-take2

Conversation

@lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Mar 13, 2026

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

There are issues with calling yarn so since it only calls a one line script to build the stubs I replaced it with that.

💡 Motivation and Context

Fix the stub build command

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • Ref: remove yarn from stub update by lucas-zimerman in #5811
  • Ref(CI): Unify stub update with android update by lucas-zimerman in #5807

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against 1e1050f

@lucas-zimerman lucas-zimerman marked this pull request as ready for review March 13, 2026 13:57
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

yarn build:replay-stubs || true
cd replay-stubs
echo "Building Stub"
./gradlew jar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed || true causes script failure on build errors

Medium Severity

The old command yarn build:replay-stubs || true intentionally suppressed build failures so the version-update workflow could continue even if the jar build failed. The new ./gradlew jar invocation drops the || true guard while the script uses set -euo pipefail, meaning any Gradle failure now aborts the entire version-update process (including when called from update-android.sh). If this strictness is intentional it's fine, but since the PR description only mentions removing yarn (not changing error handling), this looks like an accidental behavior change.

Fix in Cursor Fix in Web

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also closed/delete the current Android PR/branch

@lucas-zimerman lucas-zimerman merged commit 548f2da into main Mar 13, 2026
43 of 48 checks passed
@lucas-zimerman lucas-zimerman deleted the lz/android-stub-take2 branch March 13, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants