Ref: remove yarn from stub update#5811
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
…sentry-react-native into lz/android-stub-take2
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| yarn build:replay-stubs || true | ||
| cd replay-stubs | ||
| echo "Building Stub" | ||
| ./gradlew jar |
There was a problem hiding this comment.
Removed || true causes script failure on build errors
Medium Severity
The old command yarn build:replay-stubs || true intentionally suppressed build failures so the version-update workflow could continue even if the jar build failed. The new ./gradlew jar invocation drops the || true guard while the script uses set -euo pipefail, meaning any Gradle failure now aborts the entire version-update process (including when called from update-android.sh). If this strictness is intentional it's fine, but since the PR description only mentions removing yarn (not changing error handling), this looks like an accidental behavior change.


📢 Type of change
📜 Description
There are issues with calling yarn so since it only calls a one line script to build the stubs I replaced it with that.
💡 Motivation and Context
Fix the stub build command
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps