ci(remix): Do not run playwright install again for remix#20824
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 74bbb09. Configure here.
| "test": "yarn test:unit", | ||
| "test:integration": "run-s test:integration:clean test:integration:prepare test:integration:client test:integration:server", | ||
| "test:integration:ci": "run-s test:integration:clean test:integration:prepare test:integration:client:ci test:integration:server", | ||
| "test:integration:ci": "run-s test:integration:clean test:integration:prepare test:integration:client test:integration:server", |
There was a problem hiding this comment.
Local integration tests break: playwright install step orphaned
Medium Severity
The test:integration:prepare:playwright script is defined but never called from any pipeline. The test:integration script (used for local runs) no longer installs Playwright deps since that step was removed from test:integration:client. It likely needs to include test:integration:prepare:playwright in its run-s chain so local yarn test:integration still works.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 74bbb09. Configure here.
Member
Author
There was a problem hiding this comment.
this is fine, we can run this manually if we need to run this locally
Contributor
size-limit report 📦
|
nicohrubec
approved these changes
May 12, 2026
s1gr1d
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already install playwright in remix integration tests on CI beforehand, so no need to run this again in the test command.