fix(remix): Skip redundant playwright install-deps in CI#20858
Closed
nicohrubec wants to merge 1 commit into
Closed
fix(remix): Skip redundant playwright install-deps in CI#20858nicohrubec wants to merge 1 commit into
nicohrubec wants to merge 1 commit into
Conversation
The CI job was timing out because `test:integration:client:ci` ran `playwright install-deps` for all browsers, spending ~11 minutes downloading webkit/firefox system deps that were never used (tests only run chromium). The GH Action already installs chromium deps. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Member
|
Duplicate of #20824 which I just merged :D |
Member
Author
|
Right, forgot about that I even approved it 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test:integration:client:ciwas runningplaywright install-depsfor all browsers, even though the tests only run chromium (--project='chromium'). This was redundant with theinstall-playwrightGH Action that already installs chromium deps.test:integration:client:cinow runs playwright directly (deps already installed by GH Action)test:integration:client(local dev) now scopesinstall-depstochromiumonly