Skip to content

chore(deps): Bump testem and @xmldom/xmldom #20631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chargome wants to merge 2 commits into from
Closed

chore(deps): Bump testem and @xmldom/xmldom #20631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9508aa8
fix(deps): bump testem and @xmldom/xmldom to fix XML injection vulner…
chargome May 4, 2026
bc99bd7
fix(ember): Move testem from dependencies to devDependencies
chargome May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ember/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
"qunit": "~2.22.0",
"qunit-dom": "~3.5.0",
"sinon": "21.0.1",
"testem": "3.20.0",
Copy link
Copy Markdown

@cursor cursor Bot May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary direct devDependency for transitive-only package

Low Severity

testem is added as a direct devDependency pinned to 3.20.0, but it's already pulled in transitively by ember-cli via testem@^3.10.1. The stated goal is to bump @xmldom/xmldom to fix Dependabot alerts, which could be achieved by updating only the lockfile resolution (e.g., npx yarn-update-dependency testem) without adding a direct dependency. This introduces unnecessary maintenance burden and could diverge from ember-cli's expected testem version over time.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit bc99bd7. Configure here.

"webpack": "~5.104.1"
},
"engines": {
Expand Down
Loading
Loading