chore(deps): Bump testem and @xmldom/xmldom#20631
Closed
Conversation
chargome
changed the title
testem and @xmldom/xmldom
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…abilities Bumps testem to 3.20.0 in @sentry/ember and updates the lockfile entry for @xmldom/xmldom@^0.8.0 to 0.8.13 to fix four high-severity XML serialization vulnerabilities (CVE-2026-41673, CVE-2026-41672, CVE-2026-41674, CVE-2026-41675). Fixes Dependabot alerts #1413, #1412, #1411, #1410. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
fix/dependabot-alert-1413
branch
from
90c05be to
9508aa8
Compare
testem is a test runner and should not be a production dependency. Having it in dependencies causes every @sentry/ember consumer to install testem and all its transitive deps (express, socket.io, etc). Also dedupes testem versions in the lockfile. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
I wonder if this is needed at all of if it would not be good enough to just bump testem transitive dependency in the lockfile - e.g. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bc99bd7. Configure here.
| "qunit": "~2.22.0", | ||
| "qunit-dom": "~3.5.0", | ||
| "sinon": "21.0.1", | ||
| "testem": "3.20.0", |
There was a problem hiding this comment.
Unnecessary direct devDependency for transitive-only package
Low Severity
testem is added as a direct devDependency pinned to 3.20.0, but it's already pulled in transitively by ember-cli via testem@^3.10.1. The stated goal is to bump @xmldom/xmldom to fix Dependabot alerts, which could be achieved by updating only the lockfile resolution (e.g., npx yarn-update-dependency testem) without adding a direct dependency. This introduces unnecessary maintenance burden and could diverge from ember-cli's expected testem version over time.
Reviewed by Cursor Bugbot for commit bc99bd7. Configure here.
Contributor
size-limit report 📦
|
Member
Author
|
handled in #20634 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testemto 3.20.0 in@sentry/ember(pulls in@xmldom/xmldom@^0.9.9)@xmldom/xmldom@^0.8.0from 0.8.12 → 0.8.13🤖 Generated with Claude Code