Skip to content

ref: replace git clone with zip downloads, reuse retry machinery #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuarli wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ref: replace git clone with zip downloads, reuse retry machinery #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d372dd6
replace git clone with zip downloads, reuse retry machinery
joshuarli Apr 28, 2026
c46f8c8
review
joshuarli Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions devservices/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,6 @@ class DependencyType(StrEnum):
DEVSERVICES_ORCHESTRATOR_LABEL = "orchestrator=devservices"

DEPENDENCY_CONFIG_VERSION = "v1"
DEPENDENCY_GIT_PARTIAL_CLONE_CONFIG_OPTIONS = {
"protocol.version": "2",
"extensions.partialClone": "true",
"core.sparseCheckout": "true",
}

DEVSERVICES_RELEASES_URL = (
"https://api.github.com/repos/getsentry/devservices/releases/latest"
Expand Down
19 changes: 0 additions & 19 deletions devservices/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,6 @@ def __str__(self) -> str:
return f"DependencyError: {self.repo_name} ({self.repo_link}) on {self.branch}"


class UnableToCloneDependencyError(DependencyError):
"""Raised when a dependency is unable to be cloned."""

def __str__(self) -> str:
return f"Unable to clone dependency: {self.repo_name} ({self.repo_link}) on {self.branch}"


class InvalidDependencyConfigError(DependencyError):
"""Raised when a dependency's config is invalid."""

Expand Down Expand Up @@ -142,18 +135,6 @@ def __init__(self, command: str, returncode: int, stderr: str):
self.stderr = stderr


class GitConfigError(Exception):
"""Base class for git config related errors."""

pass


class FailedToSetGitConfigError(GitConfigError):
"""Raised when a git config cannot be set."""

pass


class ContainerHealthcheckFailedError(Exception):
"""Raised when a container is not healthy."""

Expand Down
Loading
Loading