ref: replace git clone with zip downloads, reuse retry machinery#314
ref: replace git clone with zip downloads, reuse retry machinery#314
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d372dd6. Configure here.
hubertdeng123
left a comment
hubertdeng123
left a comment
There was a problem hiding this comment.
I'm not convinced this is a better approach since the zip file is downloaded on every devservices call. Sparse checkout allowed us to return early if there weren't any changes. Can you explain more on the benefits here?
I know that git clone was creating issues in CI because of a silent runner upgrade from GitHub, but also I know that we use git clone in a lot of areas so trying to understand more here.
|
|
||
|
|
||
| def _update_dependency( | ||
| def _parse_github_repo_path(repo_link: str) -> str: |
There was a problem hiding this comment.
Is this necessary? What was nice about git clone was the ability to clone through file:// so we would no longer have that to test things out locally
2 participants
instead of getsentry/sentry#114194 we can just completely drop
gitin favor of downloading source archives at the cost of a few MB (snuba, relay) vs sparsely checking outdevservices/it's worth it for peace of mind and is overall much simpler (look at all the removed code!)
no config changes required; we can construct a github archive zip url from existing configuration
i also took the liberty to deduplicate a retry wrapper since it's now used in 3 places
also i tested this manually with fresh colima and it works