deps: upgrade phoenix_html and add phoenix_html_helpers#68
Open
meagharty wants to merge 2 commits intogeolessel:mainfrom
Open
deps: upgrade phoenix_html and add phoenix_html_helpers#68meagharty wants to merge 2 commits intogeolessel:mainfrom
meagharty wants to merge 2 commits intogeolessel:mainfrom
Conversation
Author
|
@geolessel, do you have thoughts on this? This patches the issue of the deprecation of |
meagharty
added a commit
to mbta/react-phoenix
that referenced
this pull request
Nov 20, 2024
…#1) * deps: upgrade phoenix_html and add phoenix_html_helpers * docs: update README code example with new imports for phoenix_html and phoenix_html_helpers
geolessel
approved these changes
Dec 13, 2024
Owner
geolessel
left a comment
There was a problem hiding this comment.
Yeah, I like this. Thank you. I'm going to try this in a project and if it works out, merge it and cut a new release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades to
phoenix_htmlto v4+ which moves HTML helpers tophoenix_html_helpers.From phoenix_html changelog: