chore: Use PhoenixLiveView for rendering HTML#67
Closed
abshierjoel wants to merge 1 commit intogeolessel:mainfrom
Closed
chore: Use PhoenixLiveView for rendering HTML#67abshierjoel wants to merge 1 commit intogeolessel:mainfrom
abshierjoel wants to merge 1 commit intogeolessel:mainfrom
Conversation
Author
|
Hi @geolessel, just wanted to ping and see if you had seen this. Thanks! |
Owner
|
@abshierjoel ahhh! Sorry for being such a poor open source maintainer! Thank you for the PR. If at all possible, I'd love to keep out LiveView. Without looking too closely yet, there is likely a way to get this done with regular EEx. Could you look into that? |
Owner
|
After looking at this, I noticed #68. I'm going to close this in favor of that approach. Thanks again for the PR and sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phoenix.HTMLhas deprecatedPhoenix.HTML.Tagsince the 4.X release. Because of this, thecontent_tagfunction is no longer available. I think a good path forward may be to use Phoenix Components with the ~H sigil for formatting. Unfortunately this does require bringing inphoenix_live_viewas a dependency, which may not be desirable.