-
Notifications
You must be signed in to change notification settings - Fork 11
Migrate to oxfmt #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Migrate to oxfmt #26
Changes from all commits
d92bc10
8c556a4
22e5679
3403f27
5093bb3
299bb09
a14936d
aa4835d
e243d32
ab96288
eccd4b3
07bf246
3206fa6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,4 +14,4 @@ types: | |
| - types | ||
| - wip | ||
| - release | ||
| - deps | ||
| - deps | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ on: | |
| branches: [main] | ||
| paths-ignore: | ||
| - "*.md" | ||
|
|
||
| pull_request: | ||
| branches: [main] | ||
| paths-ignore: | ||
|
|
@@ -20,29 +20,23 @@ jobs: | |
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Set node version to 17.x | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 17.x | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Cache pnpm modules | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't think caching is needed |
||
| uses: actions/cache@v2 | ||
| - name: Set node version to 20.x | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| path: ~/.pnpm-store | ||
| key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}- | ||
| node-version: 20 | ||
|
|
||
| - uses: pnpm/action-setup@v2 | ||
| with: | ||
| version: 6 | ||
| - uses: pnpm/action-setup@v4 | ||
|
|
||
| - name: Install deps | ||
| run: | | ||
| pnpm install | ||
| npx playwright install-deps chromium | ||
| pnpm --dir docs exec playwright install chromium | ||
|
|
||
| - name: Oxfmt | ||
| run: | | ||
| pnpm format:check | ||
|
|
||
| - name: Run tests | ||
| - name: Test | ||
| run: pnpm test | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "$schema": "./node_modules/oxfmt/configuration_schema.json", | ||
| "printWidth": 80, | ||
| "sortPackageJson": false, | ||
|
Comment on lines
+3
to
+4
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can enable |
||
| "ignorePatterns": [ | ||
| "node_modules", | ||
| "/coverage", | ||
| "/.next/", | ||
| "/out/", | ||
| "/build", | ||
| ".DS_Store", | ||
| ".env*", | ||
| ".husky", | ||
| "npm-debug.log*", | ||
| "yarn-debug.log*", | ||
| "yarn-error.log*", | ||
| "/public", | ||
| ".prettierignore", | ||
| "yarn.lock" | ||
| ] | ||
| } | ||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,7 +88,7 @@ export const Playground = ({ | |
| filename = "App.jsx"; | ||
| } else { | ||
| throw new Error( | ||
| `Code block is missing a filename: ${props.children}` | ||
| `Code block is missing a filename: ${props.children}`, | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does not look like lint_staged formatted files correctly in the past |
||
| ); | ||
| } | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the latest versions