Skip to content

Migrate to oxfmt#26

Draft
amanmahajan7 wants to merge 13 commits intomainfrom
am-oxfmt
Draft

Migrate to oxfmt#26
amanmahajan7 wants to merge 13 commits intomainfrom
am-oxfmt

Conversation

@amanmahajan7
Copy link
Copy Markdown
Collaborator

@amanmahajan7 amanmahajan7 self-assigned this Mar 25, 2026
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -1,3151 +1,5831 @@
lockfileVersion: 5.4
lockfileVersion: '9.0'
Copy link
Copy Markdown
Collaborator Author

@amanmahajan7 amanmahajan7 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think lockfileVersion change caused such a huge change in the lock file. We can pin pnpm in the next version. I tried to run old pnpm version but it is quite old and node 25 on local was failing

node-version: 17.x
uses: actions/checkout@v6

- name: Cache pnpm modules
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think caching is needed

uses: actions/setup-node@v3
with:
node-version: 17.x
uses: actions/checkout@v6
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the latest versions

} else {
throw new Error(
`Code block is missing a filename: ${props.children}`
`Code block is missing a filename: ${props.children}`,
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look like lint_staged formatted files correctly in the past

Comment on lines +3 to +4
"printWidth": 80,
"sortPackageJson": false,
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can enable singleQuote and trailingComma in the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants