Conversation
|
|
1 similar comment
|
|
| @@ -1,3151 +1,5831 @@ | |||
| lockfileVersion: 5.4 | |||
| lockfileVersion: '9.0' | |||
There was a problem hiding this comment.
I think lockfileVersion change caused such a huge change in the lock file. We can pin pnpm in the next version. I tried to run old pnpm version but it is quite old and node 25 on local was failing
| node-version: 17.x | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Cache pnpm modules |
There was a problem hiding this comment.
Don't think caching is needed
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 17.x | ||
| uses: actions/checkout@v6 |
There was a problem hiding this comment.
Using the latest versions
| } else { | ||
| throw new Error( | ||
| `Code block is missing a filename: ${props.children}` | ||
| `Code block is missing a filename: ${props.children}`, |
There was a problem hiding this comment.
Does not look like lint_staged formatted files correctly in the past
| "printWidth": 80, | ||
| "sortPackageJson": false, |
There was a problem hiding this comment.
We can enable singleQuote and trailingComma in the next PR.
https://oxc.rs/docs/guide/usage/formatter.html
https://oxc.rs/docs/guide/usage/formatter/migrate-from-prettier.html