Skip to content

Refactor project structure and update README for clarity#2

Open
cychitivav wants to merge 10 commits intomasterfrom
feat/enhance-README
Open

Refactor project structure and update README for clarity#2
cychitivav wants to merge 10 commits intomasterfrom
feat/enhance-README

Conversation

@cychitivav
Copy link
Contributor

  • Fix the README documentation
  • Enhance tmux scripts

…age.xml and tmux scripts for consistency with new naming conventions.

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This comment was marked as outdated.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +80 to 83
${mrs_msgs_TARGETS}
${std_srvs_TARGETS}
)

Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_link_libraries() links against ${mrs_msgs_TARGETS}, but this CMakeLists.txt never calls find_package(mrs_msgs REQUIRED) (and the code in this package doesn’t appear to use mrs_msgs). As written, CMake configuration will fail due to an undefined variable/target list. Either add the missing find_package(mrs_msgs REQUIRED) + proper linking/export, or remove ${mrs_msgs_TARGETS} from the link list.

Suggested change
${mrs_msgs_TARGETS}
${std_srvs_TARGETS}
)
${std_srvs_TARGETS}
)

Copilot uses AI. Check for mistakes.
cychitivav and others added 3 commits March 3, 2026 13:49
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added sections for ROS interfaces including Messages, Services, and Actions in the README.
@veskrdan
Copy link
Collaborator

Please fix the following when running a tmux session:

  • you should be directed straight to the template window
  • first window should run the launch.xml so that the second window can start listening
  • add the fourth window, so you know you have two services to work with: allow and ban
  • fix the launch node name so it matches the changes and services can be called

Test it ;) Also functional changes shouldn't be in refactor README branch :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants