Skip to content

feat: fc_ key websocket support — conditional apiKeyId #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbiskur merged 1 commit into from
Mar 30, 2026
+4 −2
Merged

feat: fc_ key websocket support — conditional apiKeyId #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/data-pump/flowcore-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ export function getFlowcoreClient(auth: FlowcoreDataPumpAuth, baseUrlOverride?:
const client = "apiKey" in auth
? new FlowcoreClientWithMetrics({
apiKey: auth.apiKey,
apiKeyId: auth.apiKeyId as string,
// apiKeyId is guaranteed to be set — FlowcoreDataPump.create() parses it from fc_ keys
apiKeyId: auth.apiKeyId!,
})
: new FlowcoreClientWithMetrics(auth)

Expand Down
3 changes: 2 additions & 1 deletion src/data-pump/notifier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ export class FlowcoreNotifier {
if ("apiKey" in this.options.auth) {
return {
apiKey: this.options.auth.apiKey,
apiKeyId: this.options.auth.apiKeyId as string,
// apiKeyId is guaranteed to be set — FlowcoreDataPump.create() parses it from fc_ keys
apiKeyId: this.options.auth.apiKeyId!,
}
}
const getBearerToken = this.options.auth.getBearerToken
Expand Down
Loading