feat: fc_ key websocket support — conditional apiKeyId#65
Merged
Conversation
FlowcoreDataPump.create() parses apiKeyId from fc_ keys before any code path reaches these files. The ! assertion is safe and removes the unsafe `as string` cast while being type-correct.
jbiskur
force-pushed
the
feat/fc-key-websocket-support
branch
from
2502b83 to
931f378
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apiKeyIdconditionally innotifier.tsandflowcore-client.tsas stringcast — only include when presentFlowcoreClientDepends On
apiKeyIdoptional inNotificationClient)Context
The tenant API
/notificationsendpoint already supportsfc_keys with justapi_keyparam. The data-pump was forcingapiKeyId as stringwhich passedundefinedas a string for fc_ keys.🤖 Generated with Claude Code