Skip to content

Update node.js.yml #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eranfireblocks wants to merge 1 commit into from
Closed

Update node.js.yml #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ jobs:
cache: 'npm'

- name: Install npm ${{ matrix.npm-version }}
run: npm install -g npm@^${{ matrix.npm-version }}
run: npm install -g npm@^${{ matrix.npm-version }} --force
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding --force to the global npm install disables npm’s safety checks and can mask an unsupported Node↔npm combination (or other real install issues), making CI results less meaningful. Prefer adjusting the matrix to only run supported Node/npm pairs (via strategy.matrix.include/exclude) or pinning to a compatible npm version, and keep the install without --force so incompatibilities fail loudly.

Suggested change
run: npm install -g npm@^${{ matrix.npm-version }} --force
run: npm install -g npm@^${{ matrix.npm-version }}

Copilot uses AI. Check for mistakes.

- run: npm ci
- run: npm run build --if-present
- run: npm pack
- run: npm pack
Loading