Conversation
Signed-off-by: eranfireblocks <108397990+eranfireblocks@users.noreply.github.com>
|
Your request is important to us. We will look into it shortly. (Note that this SDK code is auto generated) |
There was a problem hiding this comment.
Pull request overview
Updates the Node.js CI workflow to change how npm is installed in the build matrix, aiming to keep CI running across Node/npm combinations.
Changes:
- Add
--forceto the step that installs a matrix-selected npm version globally. - Minor workflow step diff normalization (no functional change besides the npm install flag).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Install npm ${{ matrix.npm-version }} | ||
| run: npm install -g npm@^${{ matrix.npm-version }} | ||
| run: npm install -g npm@^${{ matrix.npm-version }} --force |
There was a problem hiding this comment.
Adding --force to the global npm install disables npm’s safety checks and can mask an unsupported Node↔npm combination (or other real install issues), making CI results less meaningful. Prefer adjusting the matrix to only run supported Node/npm pairs (via strategy.matrix.include/exclude) or pinning to a compatible npm version, and keep the install without --force so incompatibilities fail loudly.
| run: npm install -g npm@^${{ matrix.npm-version }} --force | |
| run: npm install -g npm@^${{ matrix.npm-version }} |
No description provided.