Skip to content

feat: Update of Satellite-information for the ÖBB-telephone#774

Merged
lenderom merged 19 commits intofipguide:mainfrom
calvin-zeu:main
Mar 22, 2026
Merged

feat: Update of Satellite-information for the ÖBB-telephone#774
lenderom merged 19 commits intofipguide:mainfrom
calvin-zeu:main

Conversation

@calvin-zeu
Copy link
Contributor

Satellite hat den Rufnummernbereich +43517 gesperrt, durch dieses PR soll ein zusätzlicher Shortcode "satellite-oebb" geschaffen werden, der auf eine Umgehung durch eine andere Telefonnummer hinweist.

@netlify
Copy link

netlify bot commented Mar 17, 2026

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit f5b88b1
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/69c03192c019270008aa4145
😎 Deploy Preview https://deploy-preview-774--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@calvin-zeu calvin-zeu marked this pull request as draft March 17, 2026 15:38
@calvin-zeu calvin-zeu marked this pull request as ready for review March 17, 2026 15:38
therobrob
therobrob previously approved these changes Mar 21, 2026
Copy link
Member

@therobrob therobrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke @calvin-zeu für den Pull Request und deinen Input! Für mich passt das ✌️

@therobrob therobrob requested a review from lenderom March 21, 2026 09:02
@MoritzWeber0
Copy link
Member

Danke auch von meiner Seite @calvin-zeu. Ich habe noch zwei Anpassung vorgenommen:

  • Shortcodes benutzen wir, wenn Inhalte mehrfach genutzt werden sollen. Da die OEBB Information derzeit nur an einer Stelle verwendet wird, habe ich stattdessen eine Funktion zum satellite shortcode hinzugefügt, womit man zusätzliche Informationen ergänzen kann.
  • Ich habe den Text leicht angepasst, damit klar wird, warum der altnerative Weg gewählt werden muss.

@therobrob Willst du nochmal über meine Änderungen drüberschauen?

MoritzWeber0
MoritzWeber0 previously approved these changes Mar 21, 2026
@MoritzWeber0 MoritzWeber0 changed the title Update of Satellite-information for the ÖBB-telephone feat: Update of Satellite-information for the ÖBB-telephone Mar 21, 2026
lenderom
lenderom previously approved these changes Mar 22, 2026
Copy link
Member

@lenderom lenderom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🫶

@lenderom lenderom dismissed stale reviews from MoritzWeber0 and themself via f5432f9 March 22, 2026 18:10
lenderom
lenderom previously approved these changes Mar 22, 2026
@lenderom lenderom merged commit ec48ac9 into fipguide:main Mar 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants