fix: use frontmatter table name for external model override keys#120
Merged
fix: use frontmatter table name for external model override keys#120
Conversation
…ey for better key retrieval logic feat: add onNavigateRedis to Dashboard and App components to provide Redis Explorer access fix: improve discoverAllModels function to return database-prefixed model keys and update related tests chore: update comments in code for clarity and maintainability
Savid
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External models with a database and table in their SQL frontmatter (e.g.
observoor) had override keys built as database.filename (observoor.observoor_cpu_utilization) instead of database.table (observoor.cpu_utilization). Since the CBT binary identifies models by database.table, disabling these models via overrides had no effect, the keys never matched.GetExternalModelOverrideKey()to seeddata that reads both database and table from frontmatterdiscoverAllModels()to use the same key format for allowlist expansion and hybrid routing