fix(p4): use pre-v3 instruction variants on older P4 chip revisions#294
Merged
sun-xiangyu merged 1 commit intoespressif:masterfrom Apr 17, 2026
Merged
Conversation
The `esp.vsld.8 ... trunc` operand and the changed `esp.vldbc.{8,16}.ip`
immediate encoding are only available on ESP32-P4 v3.0+ (ECO5+). The
existing guard only checks the IDF version (>= 5.5.2) but not the target
chip revision, causing assembly errors when building for pre-v3 P4 chips
on IDF 5.5.x.
Add `|| defined(CONFIG_ESP32P4_SELECTS_REV_LESS_V3)` to the preprocessor
guards so the old instruction variants are used when the minimum supported
chip revision is set below v3.
Bump version to 3.3.1.
Collaborator
|
@vikramdattu, thanks for your feedback. |
6 tasks
Contributor
|
@sun-xiangyu LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esp.vsld.8 ... truncoperand and the changedesp.vldbc.{8,16}.ipimmediate encoding are only available on ESP32-P4 v3.0+ (ECO5+)>= 5.5.2) but not the chip revision, causing assembly errors when building for pre-v3 P4 chips on IDF 5.5.x|| defined(CONFIG_ESP32P4_SELECTS_REV_LESS_V3)to both guards indl_esp32p4_color_common.SError without fix
Test plan
CONFIG_ESP32P4_SELECTS_REV_LESS_V3=y(pre-v3 chip) — uses old instruction variantstruncvariant as before