feat(issue-discovery): precise post-merge edit detection upgrade#434
Open
corevibe555 wants to merge 6 commits intoentrius:testfrom
Open
feat(issue-discovery): precise post-merge edit detection upgrade#434corevibe555 wants to merge 6 commits intoentrius:testfrom
corevibe555 wants to merge 6 commits intoentrius:testfrom
Conversation
corevibe555
force-pushed
the
feature/issue-402-post-merge-edit-detection
branch
from
7a98b6a to
4adaf12
Compare
corevibe555
changed the title
corevibe555
commented
Apr 15, 2026
| authorAssociation | ||
| userContentEdits(last: 1) { | ||
| nodes { editedAt } | ||
| } |
Author
There was a problem hiding this comment.
To get last body edit, first:1 will return newest edit time, proved by manual testing
corevibe555
commented
Apr 15, 2026
| nodes { | ||
| ... on RenamedTitleEvent { createdAt } | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
To get last title edit time of the issue.
corevibe555
force-pushed
the
feature/issue-402-post-merge-edit-detection
branch
from
5233f75 to
5ac412c
Compare
Replace the noisy updated_at proxy with timeline-based detection for body and title edits only. updated_at fires on any activity (bot comments, labels, reactions), silently demoting legitimate solved issues to closed_count in active repos. - GraphQL: fetch userContentEdits + RenamedTitleEvent alongside existing closingIssuesReferences (no extra round trip) - Issue.body_or_title_edited_at: max(last body edit, last rename) - scoring.py: anti-gaming check now uses body_or_title_edited_at - Tests: benign updated_at bump ignored, real body edit demotes, pre-merge edits ignored fix fix fix fix
corevibe555
force-pushed
the
feature/issue-402-post-merge-edit-detection
branch
from
5ac412c to
a4af442
Compare
userContentEdits is reverse-chronological on GitHub, so last:1 returned the oldest body edit and the check never fired on subsequent edits. first:1 returns the newest. timelineItems is chronological, so last:1 stays correct for title renames.
corevibe555
changed the title
Author
|
@anderdc Would you review this PR? |
anderdc
requested changes
Apr 15, 2026
Collaborator
anderdc
left a comment
anderdc
left a comment
There was a problem hiding this comment.
A couple things to address:
Delete the spec file
issue_discovery/issue-discovery-rewards.md is a planning doc that was used to guide implementation. It shouldn't live in the repo long-term. Please delete it in this PR or a follow-up.
Clean up the tests
The tests cover the right scenarios but need some cleanup:
_make_issuehasdatetime = Nonedefaults — these should beOptional[datetime] = None- Lazy import of
_DiscovererDatainside_run()— no reason for this in a test file, just import at the top _merged_at()is a function returning a constant — just make it a module-level constant- Make sure the tests are actually exercising the new code path — right now they test
_collect_issues_from_prs(a private function) directly. That's fine for now, but double check the assertions are meaningful and not just passing because of default values or skipped branches
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #402
Summary
Replaces the
issue.updated_atanti-gaming logic in issue discovery scoring with precise timeline-based detection for body and title edits only. The old check false-positived on any activity (bot comments, label changes, reactions, stale-bots), silently demoting legitimate solved issues toclosed_countand unfairly cutting miner credibility in active repos.Body edit and title edit both should be checked.
This is because title and body are connected.
If title change allowed, it's possible to confuse the reviewer by changing title.
From the purpose of this feature from doc: https://docs.gittensor.io/issue-discovery.html, title is important to define scope, it's possible to inflate by just changing title.
Related Issues
Closes #402
Type of Change
Testing
Added:
tests/validator/test_issue_discovery_post_merge_edit.py— 3 cases:updated_atbump after merge (bot activity) → issue stayssolved.closed, no score.solved.Results: 3/3 new tests pass. Broader existing suite (66 validator tests) still green. Pre-existing
tree_sitterimport errors in unrelated test modules are not affected by this change.Manual testing
Before adding comment
After adding commment
After changing title
After chaing body
Checklist
body_or_title_edited_atis not persisted to DB — fine today since scoring re-fetches from GraphQL each run, but worth revisiting if any code path reconstructsIssuefrom storage)updated_atcolumn preserved)issue_discovery/issue-discovery-rewards.mdstill describes theupdated_atproxy as current behavior; should be updated in a follow-up doc PR or this one if preferred