fix: exclude auto-close event from post-merge edit detection in issue discovery scoring#444
Closed
spider-yamet wants to merge 3 commits intoentrius:testfrom
Closed
fix: exclude auto-close event from post-merge edit detection in issue discovery scoring#444spider-yamet wants to merge 3 commits intoentrius:testfrom
spider-yamet wants to merge 3 commits intoentrius:testfrom
Conversation
Collaborator
|
Closing in favor of #434 which replaces the updated_at check entirely with precise body/title edit detection via GraphQL timeline events. That fix covers this case and all other false positives (bot comments, labels, reactions). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a false positive in the post-merge edit detection for issue discovery scoring. When a PR merge auto-closes a linked issue, GitHub sets the issue's
updated_atto the close timestamp, which is always slightly aftermerged_at. The existing check treated this as a post-merge content edit, incorrectly flipping the issue from "solved" to "closed" — reducing the discoverer'ssolved_count, inflatingclosed_count, and dropping their credibility.The fix adds a guard that compares
updated_atagainstclosed_at. The penalty now only fires when the issue was genuinely edited after the close event, not when the update was the close event itself.Related Issues
Fixes #443
Type of Change
Manual testing performed:
updated_at == closed_at) is correctly classified as "solved"updated_at > closed_at(genuine post-close edit) still triggers the penaltyclosed_at = Noneconservatively triggers the penaltyChecklist