[WIP] Drop support for PHP earlier than 7.4 and upgrade PHPStan to 2.x

.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       matrix:
         operating-system: [ubuntu-latest]
-        php-versions: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
+        php-versions: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
 
     runs-on: ${{ matrix.operating-system }}
 

composer.json

@@ -6,15 +6,15 @@
 	"homepage"   : "https://donatstudios.com/SimpleCalendar",
 	"license"    : "MIT",
 	"require"    : {
-		"php": ">=7.2",
+		"php": ">=7.4",
 		"ext-calendar": "*"
 	},
 	"require-dev": {
 		"ext-dom": "*",
 		"corpus/coding-standard": "^0.6.0",
 		"donatj/drop": "^1.1",
 		"friendsofphp/php-cs-fixer": "^3.3",
-		"phpstan/phpstan": "^1.10",
+		"phpstan/phpstan": "^2.0",
 		"phpunit/phpunit": "*",
 		"squizlabs/php_codesniffer": "^3.7"
 	},

src/SimpleCalendar.php

@@ -203,10 +203,7 @@ public function setStartOfWeek( $offset ) : void {
 				throw new \InvalidArgumentException('invalid offset');
 			}
 
-			$date = date('N', $weekTime);
-			assert($date !== false);
-
-			$this->offset = intval($date) % 7;
+			$this->offset = intval(date('N', $weekTime)) % 7;
 		}
 	}
 
@@ -315,18 +312,26 @@ public function render() : string {
 	}
 
 	/**
-	 * @param array<int, mixed> $data
+	 * @template T
+	 * @param array<int, T> $data
+	 * @param-out array<int, T> $data
 	 */
 	private function rotate( array &$data, int $steps ) : void {
 		$count = count($data);
+		if( $count === 0 ) {
+			return;
+		}
+
 		if( $steps < 0 ) {
 			$steps = $count + $steps;
 		}
 
 		$steps %= $count;
-		for( $i = 0; $i < $steps; $i++ ) {
-			$data[] = array_shift($data);
+		if( $steps === 0 ) {
+			return;
 		}
+
+		$data = array_merge(array_slice($data, $steps), array_slice($data, 0, $steps));
 	}
 
 	/**

test/SimpleCalendarTest.php

@@ -16,7 +16,7 @@ public function testBadDailyHtmlDates() : void {
 			$cal = new SimpleCalendar('June 2010', 'June 5 2010');
 			$cal->addDailyHtml('foo', 'tomorrow', 'yesterday');
 		} catch( InvalidArgumentException $ex ) {
-			$this->assertTrue(true);
+			$this->addToAssertionCount(1);
 
 			return;
 		}