[WIP] Drop support for PHP earlier than 7.4 and upgrade PHPStan to 2.x#35
Draft
[WIP] Drop support for PHP earlier than 7.4 and upgrade PHPStan to 2.x#35
Conversation
Open
Agent-Logs-Url: https://github.com/donatj/SimpleCalendar/sessions/e23d84f4-11bb-4c84-b324-4434d1ef1a4d Co-authored-by: donatj <133747+donatj@users.noreply.github.com>
Copilot stopped work on behalf of
donatj due to an error
May 4, 2026 04:28
Owner
|
@copilot phpstan is currently failing |
…(), drop assertTrue(true) Agent-Logs-Url: https://github.com/donatj/SimpleCalendar/sessions/f748e819-6c6d-447d-ad48-c2d2fe8ade30 Co-authored-by: donatj <133747+donatj@users.noreply.github.com>
Author
Fixed in 309d487. There were 4 PHPStan 2.x errors:
|
Owner
|
@copilot phpcs is failing now |
… add param-out, fix risky test Agent-Logs-Url: https://github.com/donatj/SimpleCalendar/sessions/dbb21c82-dab4-4f9f-bd11-a6421b09055b Co-authored-by: donatj <133747+donatj@users.noreply.github.com>
Author
Fixed in 0a944f8. The CI was actually still failing on PHPStan (not PHPCS directly). The root cause was that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
composer.json: change PHP requirement from>=7.2to>=7.4composer.json: upgrade PHPstan from^1.10to^2.0.github/workflows/ci.yml: remove PHP 7.2 and 7.3 from the matrixcomposer updateand commit updatedcomposer.lock