feat: use DataDimension from @dhis2/analytics [DHIS2-19344]#3632
Merged
BRaimbault merged 23 commits intomasterfrom Mar 17, 2026
Merged
feat: use DataDimension from @dhis2/analytics [DHIS2-19344]#3632BRaimbault merged 23 commits intomasterfrom
BRaimbault merged 23 commits intomasterfrom
Conversation
Contributor
|
🚀 Deployed on https://pr-3632.maps.netlify.dhis2.org |
BRaimbault
commented
Mar 16, 2026
Collaborator
Author
BRaimbault
left a comment
BRaimbault
left a comment
There was a problem hiding this comment.
Ready for review
HendrikThePendric
requested changes
Mar 16, 2026
Contributor
HendrikThePendric
left a comment
HendrikThePendric
left a comment
There was a problem hiding this comment.
Looks like a good cleanup. I did leave a few minor comments though.
BRaimbault
commented
Mar 16, 2026
Collaborator
Author
BRaimbault
left a comment
BRaimbault
left a comment
There was a problem hiding this comment.
Ready for re-review
|
HendrikThePendric
approved these changes
Mar 17, 2026
dhis2-bot
added a commit
that referenced
this pull request
Mar 17, 2026
# [101.9.0](v101.8.0...v101.9.0) (2026-03-17) ### Features * use common data selector for thematic layers [DHIS2-19344] ([#3632](#3632)) ([25dd748](25dd748))
Contributor
|
🎉 This PR is included in version 101.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-19344
Description
Use
DataDimensionfrom @dhis2/analytics instead of custom selectors forThematicDialog.DataDimension:dataItem.typeasdataItem.dimensionItemType, also names differ (see changes todimConfin:src/constants/dimension.js).legendSetwith the data item list, now it is fetched on selection withsrc/hooks/useDataItemLegendSet.js.initializeThematicLayer.validateThematicLayer.Also fixes issue of unwanted periods sync on single thematic layers.
Quality checklist
Add N/A to items that are not applicable.
Screenshots