feat: add flexibility to DataDimension#1819
Merged
BRaimbault merged 7 commits intomasterfrom Mar 16, 2026
Merged
Conversation
5 tasks
|
BRaimbault
commented
Mar 16, 2026
Contributor
Author
BRaimbault
left a comment
There was a problem hiding this comment.
Ready for review
dhis2-bot
added a commit
that referenced
this pull request
Mar 16, 2026
# [29.4.0](v29.3.3...v29.4.0) (2026-03-16) ### Features * add flexibility to DataDimension ([#1819](#1819)) ([328bc5d](328bc5d))
Contributor
|
🎉 This PR is included in version 29.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Implements DHIS2-19344
Relates to dhis2/maps-app#3632
Key features
DataDimensioncomponent accepts 3 new properties:heightthat sets the height of the main transfer componentheightCalculationthat sets the height of the calculation componentmaxSelectionsthat definesmaxSelectionsand disablesenableOrderChangeif defined and = 1 so UI elements like double arrows or sorting options are disabled when only one element can be selected.Description
DataDimension'sheightis passed down to:ItemSelectorasheight, which in turn defaults toTRANSFER_HEIGHTif missing and passes it to:Transfercomponent asheightItemOptionsSelectorasheight, which in turn defaults toTRANSFER_HEIGHTif missing and passes it to:Transfercomponent asheightDataDimension'smaxSelectionsis passed down to:ItemSelectorasmaxSelections, which in turn passes it to:Transfercomponent asmaxSelectionsand also uses it to setenableOrderChangeItemOptionsSelectorasmaxSelections, which in turn passes it to:Transfercomponent asmaxSelectionsand also uses it to setenableOrderChangeDataDimension'sheightCalculationis passed down to:ItemSelectorasheightCalculation, which in turn passes it to:CalculationModalasheight, which in turn passes it to:DataElementSelector, which in turn defaults toSCROLLBOX_HEIGHTif missing and uses it to set the height to thedimension-list-scrollboxScreenshots