Skip to content

feat: add flexibility to DataDimension#1819

Merged
BRaimbault merged 7 commits intomasterfrom
feat/DHIS2-19344
Mar 16, 2026
Merged

feat: add flexibility to DataDimension#1819
BRaimbault merged 7 commits intomasterfrom
feat/DHIS2-19344

Conversation

@BRaimbault
Copy link
Contributor

@BRaimbault BRaimbault commented Mar 10, 2026

Implements DHIS2-19344

Relates to dhis2/maps-app#3632


Key features

DataDimension component accepts 3 new properties:

  • height that sets the height of the main transfer component
  • heightCalculation that sets the height of the calculation component
  • maxSelections that defines maxSelections and disables enableOrderChange if defined and = 1 so UI elements like double arrows or sorting options are disabled when only one element can be selected.

Description

  • DataDimension's height is passed down to:

    • ItemSelector as height, which in turn defaults to TRANSFER_HEIGHT if missing and passes it to:
      • Transfer component as height
    • ItemOptionsSelector as height, which in turn defaults to TRANSFER_HEIGHT if missing and passes it to:
      • Transfer component as height
  • DataDimension's maxSelections is passed down to:

    • ItemSelector as maxSelections, which in turn passes it to:
      • Transfer component as maxSelections and also uses it to set enableOrderChange
    • ItemOptionsSelector as maxSelections, which in turn passes it to:
      • Transfer component as maxSelections and also uses it to set enableOrderChange
  • DataDimension's heightCalculation is passed down to:

    • ItemSelector as heightCalculation, which in turn passes it to:
      • CalculationModal as height, which in turn passes it to:
        • DataElementSelector, which in turn defaults to SCROLLBOX_HEIGHT if missing and uses it to set the height to the dimension-list-scrollbox

Screenshots

image image

@sonarqubecloud
Copy link

@BRaimbault BRaimbault marked this pull request as ready for review March 16, 2026 09:13
Copy link
Contributor Author

@BRaimbault BRaimbault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review

@BRaimbault BRaimbault changed the title feat: add height properties to DataDimension feat: add flexibility to DataDimension Mar 16, 2026
Copy link
Contributor

@HendrikThePendric HendrikThePendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BRaimbault BRaimbault merged commit 328bc5d into master Mar 16, 2026
15 checks passed
@BRaimbault BRaimbault deleted the feat/DHIS2-19344 branch March 16, 2026 23:44
dhis2-bot added a commit that referenced this pull request Mar 16, 2026
# [29.4.0](v29.3.3...v29.4.0) (2026-03-16)

### Features

* add flexibility to DataDimension ([#1819](#1819)) ([328bc5d](328bc5d))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 29.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants