Skip to content

Bump eslint #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denis-rossati wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bump eslint #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
183332c
Bump eslint
denis-rossati Jan 30, 2026
1631913
Fix eslint
denis-rossati Jan 30, 2026
444abe8
Remove codeclimate file
denis-rossati Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions .codeclimate.yml
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions .eslintrc.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/deploy-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 22
registry-url: 'https://registry.npmjs.org'
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/validate-branch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 22

- name: Cache dependencies
id: cache-dependencies
Expand All @@ -46,7 +46,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 22

- name: Cache dependencies
id: cache-dependencies
Expand All @@ -68,7 +68,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 22

- name: Cache dependencies
id: cache-dependencies
Expand Down
13 changes: 13 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { defineConfig } from 'eslint/config';
import { configs } from '@croct/eslint-plugin';

export default defineConfig(
configs.typescript,
{
rules: {
// Disable jest rules since this project doesn't need any runtime test
'jest/no-deprecated-functions': 'off',
'@typescript-eslint/no-redundant-type-constituents': 'off',
},
}
Comment on lines +6 to +12
Copy link
Copy Markdown
Member

@Fryuni Fryuni Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these? Those rules should trigger only on test files anyway and this project doesn't have test files.

Copy link
Copy Markdown
Member Author

@denis-rossati denis-rossati Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, our "@croct/eslint-plugin" requires the jest plugin, which tries to find the jest version, and since this package doesn't have it installed, it throws Unable to detect Jest version - please ensure jest package is installed, or otherwise set version explicitly

);
Loading