Conversation
|
👋 @denis-rossati
☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood. |
| { | ||
| rules: { | ||
| // Disable jest rules since this project doesn't need any runtime test | ||
| 'jest/no-deprecated-functions': 'off', | ||
| '@typescript-eslint/no-redundant-type-constituents': 'off', | ||
| }, | ||
| } |
There was a problem hiding this comment.
Do we need these? Those rules should trigger only on test files anyway and this project doesn't have test files.
There was a problem hiding this comment.
Yes, our "@croct/eslint-plugin" requires the jest plugin, which tries to find the jest version, and since this package doesn't have it installed, it throws Unable to detect Jest version - please ensure jest package is installed, or otherwise set version explicitly
Summary
This PR will update the eslint version.
Checklist