fcos translate.go: add warn on small or constrained root partition#378
Open
prestist wants to merge 4 commits intocoreos:mainfrom
Open
fcos translate.go: add warn on small or constrained root partition#378prestist wants to merge 4 commits intocoreos:mainfrom
prestist wants to merge 4 commits intocoreos:mainfrom
Conversation
prestist
force-pushed
the
warn-on-fs-too-small
branch
from
df3fd2e to
166e0d5
Compare
bgilbert
reviewed
Aug 7, 2022
prestist
force-pushed
the
warn-on-fs-too-small
branch
6 times, most recently
from
b95add4 to
98397ca
Compare
prestist
force-pushed
the
warn-on-fs-too-small
branch
2 times, most recently
from
8a4a4c3 to
50f80a6
Compare
prestist
force-pushed
the
warn-on-fs-too-small
branch
from
50f80a6 to
8882e58
Compare
prestist
force-pushed
the
warn-on-fs-too-small
branch
2 times, most recently
from
74876cc to
78f8481
Compare
Fixes: coreos#211, the root partition needs a certain amount of space, with recent changes butane has the opportunity to warn when those expectations are not met. Check for contstraints caused by: - Partitions with out-of-order numbers - Auto-positioned partitions (StartMiB == 0 or nil) - Explicit partition positioning
Add test cases for: - Root partition constrained by disk position (not partition number) - Root partition with auto-positioned following partition (StartMiB=0) - Root partition NOT constrained when next partition has explicit StartMiB - Root partition size validation (too small, exactly 8GiB)
prestist
force-pushed
the
warn-on-fs-too-small
branch
from
78f8481 to
530a65e
Compare
prestist
changed the title
Member
|
The first commit message says fcos v0_7_exp but there is no v0_7_exp directory. May be this should be fcos v1_7_exp? |
Member
|
Minor: Typo in commit message body: "contstraints" should be "constraints" |
aaradhak
reviewed
Mar 31, 2026
| ErrReuseByLabel = errors.New("partitions cannot be reused by label; number must be specified except on boot disk (/dev/disk/by-id/coreos-boot-disk) or when wipe_table is true") | ||
| ErrWrongPartitionNumber = errors.New("incorrect partition number; a new partition will be created using reserved label") | ||
| ErrRootTooSmall = errors.New("root should have 8GiB of space assigned") | ||
| ErrRootConstrained = errors.New("root is configured too small, and has no room to expand") |
Member
There was a problem hiding this comment.
just curious if this can this be rephrased? shouldnt this error message say something like that it's configured to fill available space?
aaradhak
reviewed
Mar 31, 2026
|
|
||
| // In the boot_device.mirror case, nothing specifies partition numbers | ||
| // so match existing partitions only when `wipeTable` is false | ||
| if !util.IsTrue(disk.WipeTable) { |
Member
There was a problem hiding this comment.
Trying to understand this wipetable change. The previous code only checked reserved partlabels when wipeTable is false. The current change now runs the root validation even when wipeTable is true. I guess it is intentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#211
Note I somehow dropped the '1' in the version for FCOS in the commit messages.. but before I update the commit structure lets make sure we are happy with the functional changes. Look at the first 2 commits, i.e the exp changes this is basically propagated to all versions back to 1_3 as you can see later with the fixup commits. Once approved I will merge the fixup commits with a rename to the commits to be inclusive of the changes!