Skip to content

Wrong Cron Flow Settings #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raphael-goetz wants to merge 2 commits into
base: main
Choose a base branch
from
+76 −69
Open

Wrong Cron Flow Settings #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cfd809
drop: remove cron code data type
raphael-goetz Mar 1, 2026
fd78724
feat: added every cron field as flow setting
raphael-goetz Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 0 additions & 65 deletions definitions/cron/data_type/object/cron_code.proto.json
View file
Open in desktop

This file was deleted.

80 changes: 76 additions & 4 deletions definitions/cron/flow_type/cron.proto.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,92 @@
"identifier": "CRON",
"settings": [
{
"identifier": "CRON_CODE",
"identifier": "CRON_MINUTE",
"unique": "NONE",
"dataTypeIdentifier": "CRON_CODE",
"dataTypeIdentifier": "CRON_MINUTE",
"defaultValue": null,
"name": [
{
"code": "en-US",
"content": "Cron Code"
"content": "Minute"
}
],
"description": [
{
"code": "en-US",
"content": "Specifies the Cron Code for this flow to be called."
"content": "Defines the minute when the flow runs (e.g., 0 for on the hour, */5 for every 5 minutes)."
Copy link
Contributor

@nicosammito nicosammito Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description doesn't make any sense

Copy link
Member Author

@raphael-goetz raphael-goetz Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is wrong?

Copy link
Contributor

@nicosammito nicosammito Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In each other input I can only parse in a number or a string here I can also declare some sort of pattern like */5. How do I setup the settings if I want to execute */MON each Monday for e.g.

}
]
},
{
"identifier": "CRON_HOUR",
"unique": "NONE",
"dataTypeIdentifier": "CRON_HOUR",
"defaultValue": null,
"name": [
{
"code": "en-US",
"content": "Hour"
}
],
"description": [
{
"code": "en-US",
"content": "Defines the hour when the flow runs (e.g., 0 for midnight, 14 for 2 PM)."
}
]
},
{
"identifier": "CRON_DAY_OF_MONTH",
"unique": "NONE",
"dataTypeIdentifier": "CRON_DAY_OF_MONTH",
"defaultValue": null,
"name": [
{
"code": "en-US",
"content": "Day of the Month"
}
],
"description": [
{
"code": "en-US",
"content": "Defines the day of the month when the flow runs (e.g., 1 for first day, 15 for mid-month)."
}
]
},
{
"identifier": "CRON_MONTH",
"unique": "NONE",
"dataTypeIdentifier": "CRON_MONTH",
"defaultValue": null,
"name": [
{
"code": "en-US",
"content": "Month"
}
],
"description": [
{
"code": "en-US",
"content": "Defines the month when the flow runs (e.g., 1 for January, 12 for December)."
}
]
},
{
"identifier": "CRON_DAY_OF_WEEK",
"unique": "NONE",
"dataTypeIdentifier": "CRON_DAY_OF_WEEK",
"defaultValue": null,
"name": [
{
"code": "en-US",
"content": "Day of the Week"
}
],
"description": [
{
"code": "en-US",
"content": "Defines the weekday when the flow runs (e.g., 0 or SUN for Sunday, MON-FRI for weekdays)."
Copy link
Contributor

@nicosammito nicosammito Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I can put a number and a string inside the settings?

Copy link
Member Author

@raphael-goetz raphael-goetz Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For days of the week you can use 0–6 or MON–SAT

Copy link
Contributor

@nicosammito nicosammito Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup sound good

}
]
}
Expand Down