Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the CRON flow type definition to model cron scheduling as five individual flow settings (minute/hour/day-of-month/month/day-of-week) instead of a single CRON_CODE object, aligning the definition with how the cron adapter expects settings (per #253).
Changes:
- Replaced the
CRON_CODEflow setting with five separate CRON field settings in the CRON flow type definition. - Removed the
CRON_CODEobject data type definition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
definitions/cron/flow_type/cron.proto.json |
Defines five individual cron field settings (minute, hour, day-of-month, month, day-of-week) for the CRON flow type. |
definitions/cron/data_type/object/cron_code.proto.json |
Removes the no-longer-used CRON_CODE object data type definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "code": "en-US", | ||
| "content": "Specifies the Cron Code for this flow to be called." | ||
| "content": "Defines the minute when the flow runs (e.g., 0 for on the hour, */5 for every 5 minutes)." |
There was a problem hiding this comment.
This description doesn't make any sense
There was a problem hiding this comment.
In each other input I can only parse in a number or a string here I can also declare some sort of pattern like */5. How do I setup the settings if I want to execute */MON each Monday for e.g.
| "description": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "Defines the weekday when the flow runs (e.g., 0 or SUN for Sunday, MON-FRI for weekdays)." |
There was a problem hiding this comment.
So I can put a number and a string inside the settings?
There was a problem hiding this comment.
For days of the week you can use 0–6 or MON–SAT
Resolves: #253