Feature: Remove Setup Path References from Static Launch Files#339
Merged
Conversation
tonybaltovski
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Platform Launch File
Replaced the
setup_pathargument in all platform related launch files:description.launch.py: Now requires URDF path to be passed as argument insteadcontrol.launch.py: Now requires path tocontrol.yamlinstead of inferring it from thesetup_pathroot directory, defaults to the static file,generic/empty.yamllocalization.launch.py: Now requires path tolocalization.yaml, defaults to the static filegeneric/localization.yamlteleop_base.launch.py: Now requires path to bothtwist_mux.yamlandteleop_interactive_markers.yaml, defaults to the static fileconfig/twist_mux.yamlandgeneric/teleop_interactive_markers.yamlteleop_joy.launch.py: Now requires path toteleop_joy.yamlplatform.launch.py: Top level launch file now exposes all of the new arguments listed above.2. Manipulators Launch File
Replace the
setup_pathargument in all manipulator launch files:control.launch.py: Now requires path tocontrol.yaml, does not have a default.moveit.launch.py: Now requiresnamespace,robot_urdf,robot_srdf, andconfig_moveit, none have defaults.manipulators.launch.py: Top level launch file now exposes all of the new arguments listed above.3. Launch Generator
Due to the launch arguments changing, the launch generator was modified to provide the new arguments in the generated launch files.