fix: proper crate layout and resolve all clippy warnings#124
Open
shivv23 wants to merge 1 commit intoc2siorg:mainfrom
Open
fix: proper crate layout and resolve all clippy warnings#124shivv23 wants to merge 1 commit intoc2siorg:mainfrom
shivv23 wants to merge 1 commit intoc2siorg:mainfrom
Conversation
Sandipmandal25
suggested changes
Mar 22, 2026
Contributor
Sandipmandal25
left a comment
There was a problem hiding this comment.
hi @shivv23
This is the same pattern instead of fixing the existing PR a new one has been opened. PRs #73, #121, #123 and now #124 are all open and doing overlapping things. Please close the older ones and consolidate into a single PR, otherwise this creates and unmanageable number of conflicts for everyone working on the repo. please discuss things before opening again a new consolidated pr. Thank you so much for trying to resolve the issue.
Comment on lines
+1
to
+10
| pub mod errors; | ||
| pub mod traits; | ||
| pub mod types; | ||
| pub mod aws; | ||
| pub mod azure; | ||
| pub mod gcp; | ||
| pub mod digiocean; | ||
|
|
||
| #[cfg(test)] | ||
| mod tests; |
Contributor
There was a problem hiding this comment.
same pattern again this change does not belong to this pr.
This was referenced Mar 23, 2026
Author
|
@Sandipmandal25 Thanks for your review and appreciation! Have done the required tasks. Thanks again! |
This was referenced Mar 24, 2026
2687af4 to
d59c12e
Compare
d59c12e to
6ffaec7
Compare
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split the crate into proper library layout with lib.rs as the canonical module export surface, and resolve all clippy warnings to make the PR mergeable.
Changes
Crate Layout:
Clippy Fixes:
Validation
cargo clippy --lib --all-features -- -D warnings✓ passescargo check --lib✓ passescargo check✓ passes