feat(errors): use thiserror for improved error handling#122
Open
shivv23 wants to merge 5 commits intoc2siorg:mainfrom
Open
feat(errors): use thiserror for improved error handling#122shivv23 wants to merge 5 commits intoc2siorg:mainfrom
shivv23 wants to merge 5 commits intoc2siorg:mainfrom
Conversation
…arnings - Add lib.rs as canonical module export surface - Simplify main.rs to minimal binary entrypoint - Remove invalid Cargo.toml entries (dev-dependency loop, language block) - Export token_provider module in traits - Fix private module visibility for aws_dns and aws_loadbalancer - Remove unused LlmStreamEvent import in vertex.rs - Add PartialEq derive to ModelRef enum - Fix test imports and assertions for dns/lb operations
- Replace manual Error implementation with thiserror derive macro - Simplify CloudError enum with cleaner attribute-based error messages - Add helper constructors rate_limit() and rate_limit_after() - Maintain backward compatibility with existing Error trait impl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor CloudError to use thiserror derive macro for cleaner error handling.
Changes
thiserrordependencyrate_limit()andrate_limit_after()#[error]attribute messages for cleaner error outputWhy
Validation
cargo clippy --lib --all-features -- -D warningspassesDependencies
Requires #124 to be merged first (establishes lib.rs structure).