container: Add export --format=tar command#2018
Draft
cgwalters wants to merge 1 commit intobootc-dev:mainfrom
Draft
container: Add export --format=tar command#2018cgwalters wants to merge 1 commit intobootc-dev:mainfrom
cgwalters wants to merge 1 commit intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a bootc container export --format=tar command, along with extensive testing infrastructure using Anaconda in QEMU. The implementation of the export functionality is solid, but I've found a potential issue with error handling when creating directories in the tar archive. Additionally, there's an opportunity to simplify the new test harness code by using a standard library for base64 encoding instead of a custom implementation. Finally, I've suggested a clarification in the new documentation to make an example kickstart script less redundant.
cgwalters
force-pushed
the
tar-export-work
branch
4 times, most recently
from
a1a7444 to
9e3909b
Compare
cgwalters
commented
Feb 26, 2026
cgwalters
force-pushed
the
tar-export-work
branch
2 times, most recently
from
5a7e853 to
3a98558
Compare
Some people want to use container build tools, but for compatibility with older systems export a tar format of the OS state e.g. Anaconda liveimg expects this. Basically this is only *slightly* more than just `tar cf`; we need to handle SELinux labeling and move the kernel. Note in order to test this we grew a whole new anaconda.rs, but this is mitigated for now by moving most of the qemu logic into bcvk. Ref: bootc-dev#1957 Assisted-by: OpenCode (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
tar-export-work
branch
from
3a98558 to
5a6dc6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some people want to use container build tools, but for compatibility with older systems export a tar format of the OS state e.g. Anaconda liveimg expects this.
Basically this is only slightly more than just
tar cf; we need to handle SELinux labeling and move the kernel.Ref: #1957
Assisted-by: OpenCode (Sonnet 4.5)