Open
Conversation
In bootc-dev/bootc#2018 we want to run an Anaconda install - but reusing host content mounted via virtiofs, and we keep running into this same problem of while we can do it with libvirt/virt-install, there's some nontrivial glue needed there, and there's *so many* advantages to directly running qemu (especially lifecycle binding, low level control) and we already are carrying qemu code here anyways. So extend our qemu logic to support ISO images, along with: - serial_log field for directing serial console to a file - no_reboot flag to prevent automatic reboot Assisted-by: OpenCode (claude-opus-4-5-20250114) Signed-off-by: Colin Walters <walters@verbum.org>
Per previous commit we're still carrying direct qemu code, and we really do want to use the modern default machine types. This came up as part of deduplicating our qemu logic with that generated for custom bootc testing. This mirrors the machine types used by bcvk's libvirt integration (see crates/kit/src/arch.rs) for consistency between direct QEMU and libvirt code paths. Assisted-by: OpenCode (claude-opus-4-5@20251101) Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several useful enhancements to the QEMU wrapper, including support for ISO booting, configurable machine types, serial log output, and a no-reboot option. The changes are well-implemented, with corresponding updates to configuration, validation, and the VM spawning logic. A new test case for the ISO boot configuration is also included. I have one suggestion to improve the validation logic for better consistency and robustness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for bootc-dev/bootc#2018