add termination checker#71
Closed
balajz wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Bubble Tea UI input handling so the Enter key better distinguishes between “statement complete” (ready to execute) vs “multi-line input” (insert newline), by introducing an explicit SQL termination/completeness check in the model.
Changes:
- Adds an Enter-key handler in the UI model to trigger execution only when the current input is considered complete.
- Introduces a helper function (
sqlTerminationChecker) that treats empty input, backslash-prefixed meta-commands, and semicolon-terminated SQL as complete.
Comment on lines
+317
to
+326
| func sqlTerminationChecker(s string) bool { | ||
| trimmed := strings.TrimSpace(s) | ||
| if trimmed == "" { | ||
| return true | ||
| } | ||
| if strings.HasPrefix(trimmed, "\\") { | ||
| return true | ||
| } | ||
| return strings.HasSuffix(trimmed, ";") | ||
| } |
Comment on lines
+317
to
+326
| func sqlTerminationChecker(s string) bool { | ||
| trimmed := strings.TrimSpace(s) | ||
| if trimmed == "" { | ||
| return true | ||
| } | ||
| if strings.HasPrefix(trimmed, "\\") { | ||
| return true | ||
| } | ||
| return strings.HasSuffix(trimmed, ";") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the user input handling logic in the UI model to better determine when SQL statements are complete and ready for execution. The main improvement is the introduction of a new function to check for SQL statement termination, which enhances how the application responds to the Enter key.