Skip to content

fix: use platform-aware URL opener on Windows #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fuxialexander wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use platform-aware URL opener on Windows #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/commands/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,17 @@ interface DeviceTokenError {
}

function openUrl(url: string): void {
const cmd = platform() === 'darwin' ? 'open' : 'xdg-open'
exec(`${cmd} ${JSON.stringify(url)}`, () => {
const plt = platform()
let cmd: string
if (plt === 'darwin') {
cmd = `open ${JSON.stringify(url)}`
} else if (plt === 'win32') {
// On Windows, `start` is a shell built-in — must invoke via cmd /c
cmd = `cmd /c start "" ${JSON.stringify(url)}`
} else {
cmd = `xdg-open ${JSON.stringify(url)}`
}
exec(cmd, () => {
// Ignore errors (e.g., no browser available)
})
}
Expand Down