fix: use platform-aware URL opener on Windows#6
Open
fuxialexander wants to merge 1 commit intomainfrom
Open
Conversation
On Windows, `xdg-open` does not exist. Replace with `cmd /c start` for Windows, keeping `open` for macOS and `xdg-open` for Linux. Addresses astro-anywhere/astro-agent#130 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openUrl()inauth.tsto usecmd /c starton Windows instead ofxdg-openxdg-openis a Linux-only utility and silently fails on Windows, preventing browser auto-open during device auth flowopenfor macOS andxdg-openfor LinuxRoot cause
The original code assumed non-macOS == Linux:
xdg-opendoes not exist on Windows, so the browser never opens during login.Fix
Test plan
astro loginstill opens browser correctlyastro loginstill opens browser correctlyastro loginnow opens browser viacmd /c startCloses astro-anywhere/astro-agent#130 (partial — the agent-runner has its own identical bug in
setup.ts'stryOpenUrl()andstart.ts's background spawn)🤖 Generated with Claude Code