Conversation
…dback in reconfigure-version-skew James (Oracle TL) post-merge review on PR #47 (commit 4367296663): 'CONFIG GET' is Redis/Valkey-specific, but the silent regression detection methodology should be cross-engine. Suggested generalization to 'engine-specific runtime readback' with engine examples. This fixup adds an engine-neutral readback command table in chapter 5 showing the runtime readback command/source per engine: - Valkey / Redis: CONFIG GET - MariaDB / MySQL: SHOW VARIABLES / SELECT @@param - PostgreSQL: SHOW / current_setting / pg_reload_conf - Oracle: SHOW PARAMETER / v$parameter - SQL Server: sys.configurations / sp_configure - OceanBase: __all_sys_parameter / SHOW PARAMETERS Plus generalizes 3 strategic mentions from 'CONFIG GET' to 'engine readback (e.g. CONFIG GET / v$parameter / SHOW VARIABLES)' style: - chapter 1 silent regression definition (line 40) - chapter 2 KB version inference clue (line 85) - chapter 5 actionable verification rule (line 156) Trap T4 'CONFIG SET silent +OK' kept as Redis/Valkey-specific because it's a genuine engine-specific behavior, not a generalization candidate. Other CONFIG GET mentions in chapter 7/8 left because they appear in Redis/Valkey-specific examples / test matrices. This is exactly the cross-engine generalization westonnnn requested to be visible in parent docs (msg=ea854a7a / 8c0b2e62 cross-engine usage annotation convention).
This was referenced May 3, 2026
6 tasks
weicao
added a commit
that referenced
this pull request
May 4, 2026
…ection (#52) Closes 6 nits across PR #50 + #51 (Fix validation sub-section abstracts / 设计教训 anti-pattern statements / Guard v1 strength progression abstracts / Source evidence index cross-repo path prefix) + adds new SKILL-INDEX ### OceanBase section with 2 case entries closing the cases/oceanbase/-to-SKILL-INDEX sync gap. Pure additive; methodology body unchanged. Same retrofit pattern as PR #29/#35/#41/#45/#48/#49.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes James's post-merge review on PR #47 (comment 4367296663):
CONFIG GETis Redis/Valkey-specific but the silent-regression detection methodology should be cross-engine.Adds engine-neutral runtime readback command table in chapter 5 showing the readback command per engine:
CONFIG GETSHOW VARIABLES/SELECT @@paramSHOW/current_settingSHOW PARAMETER/v$parametersys.configurations/sp_configure__all_sys_parameterPlus generalizes 3 strategic mentions in chapter 1 / 2 / 5 from
CONFIG GETtoengine runtime readback (e.g. CONFIG GET / v$parameter / SHOW VARIABLES)style.Why this matters
addon-reconfigure-version-skew-guideclaims cross-version applicability for "任何在 KB 多个发布带之间复用的 addon" but body only used Redis-specific examples. Per westonnnn cross-engine usage annotation convention (msg=ea854a7a / 8c0b2e62), parent doc must surface engine-specific examples for all engines that the methodology applies to, not just one.This is also a Cat-5 ROI instance (per Helen / Kevin discussion): doc-as-discovery-vector for engine-specific assumption — James (Oracle TL) noticed and flagged within minutes of PR #47 merge.
Out of scope (deliberately not modified)
CONFIG GETmentions in case-specific examples / test matrices left as engine-specific examplesTest plan