Conversation
…ection Closes 6 nits across PR #50 + #51 (per Allen curator review commitment + Noah ack): PR #50 (oceanbase-repl-post-failover-stale-ro-case.md) nit (c): - Fix validation 主路径 sub-section: add 1-line abstract showing happy path with v2 freshness gate fix correctly detects stale-ro (TDD designed FAIL = 21/1/0) - Fix validation ground_truth_unavailable sub-section: add abstract showing conservative fail-stop path when standby has no seed, validates 'cannot read ground truth -> fail-stop, not silent skip' design intent PR #51 (oceanbase-repl-peer-primary-acked-write-divergence-case.md): - nit (a): Source evidence index gets cross-repo path prefix 'kubeblocks-tests/oceanbase/' added to all work/ paths + explicit intro note that sha256 verification doesn't depend on path stability - nit (b): 设计教训 2 cross-addon contracts each get explicit Anti-pattern statement (sidecar single-pod view as sufficient PRIMARY publish criterion / peer probe error propagation to outer kbagent deadline) - nit (c): Guard v1 N=1 / N=5 / N=10 sub-sections each get 1-line abstract showing the strength evidence progression (N=1 baseline / N=5 main path stable but timeout-isolation untouched / N=10 cycle04 hits timeout-isolation finally validating it) SKILL-INDEX (structural gap surfaced by fire #14 dashboard): - Add new '### OceanBase' section between Oracle and Methodology - Both case entries with full descriptions including parent doc cross-refs + P0/P1 framing + Guard validation N=1/5/10 progression Pure additive: methodology body / sub-section organization unchanged beyond nit-level abstracts. SKILL-INDEX cross-engine annotation rate delta: 0 -> 2 OB entries (closes the cases/oceanbase/ -> SKILL-INDEX sync gap that landed as silent debt with PR #50 + PR #51).
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes 6 nits across PR #50 + PR #51 (per curator review commitment + Noah ack), plus a SKILL-INDEX structural gap surfaced by fire #14 dashboard refresh.
PR #50 nit (c) — Fix validation sub-section abstracts
PR #51 nits (a/b/c)
kubeblocks-tests/oceanbase/added to allwork/paths + explicit intro note that sha256 verification doesn't depend on path stabilitySKILL-INDEX OB section (structural gap surface)
PR #50 + #51 landed cases/oceanbase/ but SKILL-INDEX still had only mariadb / valkey / oracle / methodology sections. Adds new
### OceanBasesection between Oracle and Methodology with both case entries (full descriptions + parent doc cross-refs + P0/P1 framing + Guard validation progression).Why this matters
Closes silent debt: case files merged without SKILL-INDEX entries means corpus reader can't find them via the primary navigation entry. Per cross-engine usage annotation convention (westonnnn directive), every case must be discoverable from SKILL-INDEX.
Pure additive (no methodology body changes beyond nit-level abstracts and anti-pattern statements; SKILL-INDEX gets new section). Same retrofit pattern as PR #29 / PR #35 / PR #41 / PR #45 / PR #48 / PR #49.
Test plan