Skip to content

framework/spring: throw RuntimeException when fail to start or load a module #13186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weizhouapache wants to merge 2 commits into
base: 4.22
Choose a base branch
from
Open

framework/spring: throw RuntimeException when fail to start or load a module #13186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d831f37
framework/spring: throw RuntimeException when fail to start or load a…
weizhouapache May 19, 2026
e9ca574
apply suggestion
weizhouapache May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...cle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ public void with(ComponentLifecycle lifecycle) {
try {
lifecycle.start();
} catch (Exception e) {
logger.error("Error on starting bean {} - {}", lifecycle.getName(), e.getMessage(), e);
logger.error("Error on starting bean [{}] due to: {}", lifecycle.getName(), e);
throw new CloudRuntimeException("Failed to start bean [" + lifecycle.getName() + "]");
}

if (lifecycle instanceof ManagementBean) {
Expand Down
12 changes: 4 additions & 8 deletions .../main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,8 @@ public void with(ModuleDefinition def, Stack<ModuleDefinition> parents) {
logger.debug(String.format("Could not get module [%s] context bean.", moduleDefinitionName));
}
} catch (BeansException e) {
logger.warn(String.format("Failed to start module [%s] due to: [%s].", moduleDefinitionName, e.getMessage()));
if (logger.isDebugEnabled()) {
logger.debug(String.format("module start failure of module [%s] was due to: ", moduleDefinitionName), e);
}
logger.error("Failed to start module [{}] due to: {}", def.getName(), e);
throw new RuntimeException(String.format("Failed to start module [%s]", def.getName()));
}
} catch (EmptyStackException e) {
logger.warn(String.format("Failed to obtain module context due to [%s]. Using root context instead.", e.getMessage()));
Expand Down Expand Up @@ -147,10 +145,8 @@ public void with(ModuleDefinition def, Stack<ModuleDefinition> parents) {
logger.debug("Failed to obtain module context: ", e);
}
} catch (BeansException e) {
logger.warn(String.format("Failed to start module [%s] due to: [%s].", def.getName(), e.getMessage()));
if (logger.isDebugEnabled()) {
logger.debug(String.format("module start failure of module [%s] was due to: ", def.getName()), e);
}
logger.error("Failed to load module [{}] due to: {}", def.getName(), e);
throw new RuntimeException(String.format("Failed to load module [%s]", def.getName()));
}
}
});
Expand Down
Loading