framework/spring: throw RuntimeException when fail to start or load a module#13186
framework/spring: throw RuntimeException when fail to start or load a module#13186weizhouapache wants to merge 2 commits into
Conversation
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13186 +/- ##
============================================
- Coverage 17.67% 17.67% -0.01%
Complexity 15788 15788
============================================
Files 5922 5922
Lines 533123 533120 -3
Branches 65201 65199 -2
============================================
- Hits 94242 94240 -2
+ Misses 428237 428235 -2
- Partials 10644 10645 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17906 |
|
@blueorangutan test |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
winterhazel
left a comment
There was a problem hiding this comment.
Tested. Way less errors are logged now on a startup failure.
|
[SF] Trillian test result (tid-16108)
|
Description
This PR fixes the issue that when fail to start cloudstack-management service, there are huge amount of logs which are misleading and difficult to address the root cause.
Steps to reproduce the issue
/etc/cloudstack/management/db.properties, for examplePrior, there are hundreds of errors like
No bean named 'DefaultConfigResources' availableWith this change, these errors do not appear. only get few errors like
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?