Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CALCITE-7353] introduce Milvus adapter with scan and convention support #4925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
[CALCITE-7353] introduce Milvus adapter with scan and convention support #4925
Changes from all commits
88fd7caFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 47 in milvus/src/main/java/org/apache/calcite/adapter/milvus/convention/MilvusRel.java
Make table a static final constant or non-public and provide accessors if needed.
Check warning on line 48 in milvus/src/main/java/org/apache/calcite/adapter/milvus/convention/MilvusRel.java
Make milvusTable a static final constant or non-public and provide accessors if needed.
Check warning on line 49 in milvus/src/main/java/org/apache/calcite/adapter/milvus/convention/MilvusRel.java
Make rowType a static final constant or non-public and provide accessors if needed.
Check warning on line 50 in milvus/src/main/java/org/apache/calcite/adapter/milvus/convention/MilvusRel.java
Make milvusOptions a static final constant or non-public and provide accessors if needed.
Check warning on line 53 in milvus/src/main/java/org/apache/calcite/adapter/milvus/convention/MilvusRel.java
Make filterCondition a static final constant or non-public and provide accessors if needed.
Check warning on line 56 in milvus/src/main/java/org/apache/calcite/adapter/milvus/convention/MilvusRel.java
Make projectRowType a static final constant or non-public and provide accessors if needed.
Check warning on line 57 in milvus/src/main/java/org/apache/calcite/adapter/milvus/convention/MilvusRel.java
Make projects a static final constant or non-public and provide accessors if needed.
Check warning on line 60 in milvus/src/main/java/org/apache/calcite/adapter/milvus/convention/MilvusRel.java
Make vectorDistanceExpr a static final constant or non-public and provide accessors if needed.
Check warning on line 61 in milvus/src/main/java/org/apache/calcite/adapter/milvus/convention/MilvusRel.java
Make vectorDistanceFieldIndex a static final constant or non-public and provide accessors if needed.
Check warning on line 62 in milvus/src/main/java/org/apache/calcite/adapter/milvus/convention/MilvusRel.java
Make sortOrder a static final constant or non-public and provide accessors if needed.
Check warning on line 63 in milvus/src/main/java/org/apache/calcite/adapter/milvus/convention/MilvusRel.java
Make limit a static final constant or non-public and provide accessors if needed.
Check warning on line 70 in milvus/src/main/java/org/apache/calcite/adapter/milvus/convention/MilvusRel.java
Replace this assert with a proper check.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.